在这种情况下，一般异常处理不是那么糟糕吗？ [关闭]

在下面的代码中，我尝试发送一组通知，我想知道通知是否已成功发送（稍后将其放入数据库中，这样就不再发送它）。

我抓到了是不是很糟糕Exception这里？我真的不在乎未发送通知的原因。

private static async Task<List<Tuple<NotificationToSend, bool>>> SendNotificationsAsync(IEnumerable<NotificationToSend> notificationsToSend)
{
    var tuples = new List<Tuple<NotificationToSend, bool>>();

    using (var smtpClient = new SmtpClient())
    {
        foreach (var notification in notificationsToSend)
        {
            bool sentSuccessfully;

            try
            {
                var mailMessage = new MailMessage
                {
                    Subject = notification.Subject,
                    Body = $"{notification.Text} <br /> This notification was sent automatically",
                    IsBodyHtml = true
                };

                mailMessage.To.Add(notification.ToEmail);

                await smtpClient.SendMailAsync(mailMessage);
                sentSuccessfully = true;
            }
            catch (Exception e)
            {
                sentSuccessfully = false;
                // Here I also plan to log the exception
            }

            var tuple = new Tuple<NotificationToSend, bool>(notification, sentSuccessfully);
            tuples.Add(tuple);
        }
    }

    return tuples;
}

你永远不应该使用catch(Exception e)，您应该只捕获您知道可以抛出的异常。并使用 SmtpClientMSDN 文档 https://learn.microsoft.com/en-us/dotnet/api/system.net.mail.smtpclient.sendasync?view=netframework-4.8表示可以抛出以下四种异常之一：

• 参数空异常 https://learn.microsoft.com/en-us/dotnet/api/system.argumentnullexception?view=netframework-4.8
• 无效操作异常 https://learn.microsoft.com/en-us/dotnet/api/system.invalidoperationexception?view=netframework-4.8
• 对象处置异常 https://learn.microsoft.com/en-us/dotnet/api/system.objectdisposedexception?view=netframework-4.8
• SMTP异常 https://learn.microsoft.com/en-us/dotnet/api/system.net.mail.smtpexception?view=netframework-4.8

所以你应该这样做：

var sentSuccessfully = false;

var mailMessage = new MailMessage
{
    Subject = notification.Subject,
    Body = $"{notification.Text} <br /> This notification was sent automatically",
    IsBodyHtml = true
};

MailMessage.To.Add(notification.ToEmail);

try
{
    await smtpClient.SendMailAsync(mailMessage);
    sentSuccessfully = true;
}
catch (ArgumentNullException e)
{
    sentSuccessfully = false;
    // Handle Argument Exception
}
catch (InvalidOperationException e)
{
    sentSuccessfully = false;
    // Handle InvalidOperation Exception
}
catch (ObjectDisposedException e)
{
    // This one shouldn't happen, so you could leave it out
    sentSuccessfully = false;
    // Do Handle ObjectDisposed Exception
}
catch (SmtpException e)
{
    sentSuccessfully = false;
    // Handle Smtp Exception
}

这样做的原因是更好的日志记录，如果您知道引发的异常，日志可能会显示类似“引发了 ArgumentNullException，*插入可能的原因解释*”之类的内容

或者，如果您想以相同的方式处理所有异常：

try
{
    await smtpClient.SendMailAsync(mailMessage);
    sentSuccessfully = true;
}
catch (Exception e) when (e is ArgumentNullException || 
    e is InvalidOperationException || 
    e is ObjectDisposedException || 
    e is SmtpException)
{
    sentSuccessfully = false;
    // Handle exception
}