这是我的代码,我关闭并打开阅读器,但它仍然无法工作。几个线程可以同时访问这个函数,但是有一个锁。它一开始会工作几次,但迟早我会收到异常“阅读器关闭时调用 Read 的尝试无效”
private IList<BursaUser> GetUsers(SqlCommand cmd)
{
IList<User> users = new List<User>();
User user;
lock (thisLock)
{
SqlDataReader dr = null;
try
{
Conn.Open();
dr = cmd.ExecuteReader(CommandBehavior.CloseConnection);
while (dr.Read())
{
user = new User
{
UserId = Convert.ToInt32(dr["WorkerNum"]),
CompanyName = dr["CompanyName"].ToString(),
WorkerName = dr["WorkerFirstName"] + " " + dr["WorkerFamilyName"],
Phone = dr["Phone"].ToString()
};
if (dr["QueueNum"] != null && dr["QueueNum"] != DBNull.Value)
{
user.Queue = new Queue
{
HasAlreadyEntered =
dr["flgAppear"] != null && dr["flgAppear"].ToString() == "Y",
IsFromWebsite = dr["TookFrom"].ToString() == "1",
IsMelutash = dr["IsMelutash"].ToString() == "1",
TimeOrdered = DateTime.Parse(dr["DateTime1"].ToString()),
QueueNum = Convert.ToInt32(dr["QueueNum"]),
SMS = dr["SMSCode"].ToString()
};
}
users.Add(user);
}
}
catch (Exception e)
{
throw e;
}
finally
{
if (dr != null)
{
dr.Close();
dr.Dispose();
}
}
return users;
}
}
是什么赋予了?
让我们尝试稍微改进一下这段代码:
private IEnumerable<BursaUser> GetUsers()
{
using (var conn = new SqlConnection(SomeConnectionString))
using (var cmd = conn.CreateCommand())
{
conn.Open();
cmd.CommandText = "SELECT WorkerNum, CompanyName, ... FROM Users";
using (var reader = cmd.ExecuteReader())
{
while (reader.Read())
{
var user = new User
{
UserId = reader.GetInt32(reader.GetOrdinal("WorkerNum")),
CompanyName = reader.GetString(reader.GetOrdinal("CompanyName")),
// TODO: complete other fields
};
// TODO: do the tests and complete the complex properties
yield return user;
}
}
}
}
现在这段代码是完全可重入且线程安全的。你不需要任何锁定。
本文内容由网友自发贡献,版权归原作者所有,本站不承担相应法律责任。如您发现有涉嫌抄袭侵权的内容,请联系:hwhale#tublm.com(使用前将#替换为@)